GH-121970: Make DeprecatedRemoved a subclass of VersionChange#121971
Merged
AA-Turner merged 3 commits intopython:mainfrom Jul 19, 2024
Merged
GH-121970: Make DeprecatedRemoved a subclass of VersionChange#121971AA-Turner merged 3 commits intopython:mainfrom
DeprecatedRemoved a subclass of VersionChange#121971AA-Turner merged 3 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The majority of the code was duplicated. A future improvement would be to add some sort of method to
VersionChangefor determining the version and labels that we could override in this subclass, rather than the somewhat convoluted method here.Also allow the
.. versionremoved::directive to be used whilst we still support older versions of Sphinx.A
pyspecific#121970📚 Documentation preview 📚: https://cpython-previews--121971.org.readthedocs.build/